essay / code-review
The PR review paradox: why your team scrutinizes typos and rubber-stamps rewrites
The amount of time spent reviewing a pull request is inversely proportional to how much it can actually break production.
I was auditing some of our past pull requests to put together better review guidelines. I love a thorough review, but the pattern I noticed in our PR history is hilariously backward.
The level of scrutiny a PR gets depends entirely on how trivial it is.
The one-line PR
Tweaking a single variable name. Prepare for a masterclass in overthinking. The comment section immediately turns into a philosophical debate:
- “Are we absolutely sure
datais expressive enough? What about future readability?” - “Let’s hop on a quick call to discuss the semantic implications of using a boolean here.”
- “Should we extract this string into a configuration file just in case we need to scale it in 5 years?”
The monster PR
2000 lines. Kusto query doing a complex tree traversal. Overhauling core architecture, database migrations, and the entire payment gateway.
Approved in 45 seconds with a single “LGTM!”
There is zero chance anyone actually read that.
Parkinson’s Law of Triviality
This is bike-shedding, alive and well in tech. We will happily argue for three days over a naming convention, but blindly wave through a massive system rewrite before our coffee gets cold.
And this problem is about to get significantly worse. With AI cranking out PRs nonstop, the volume of code that needs real review is increasing while the cognitive budget for review stays flat. The rubber-stamp approval becomes the path of least resistance.
The teams that figure out how to allocate review attention proportionally to blast radius, rather than inversely to diff size, are going to have meaningfully fewer production incidents. That is a process design problem, not a discipline problem.